-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/room booking #245
Open
BrandonDoza
wants to merge
33
commits into
turingschool-examples:main
Choose a base branch
from
BrandonDoza:feature/room-booking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/room booking #245
BrandonDoza
wants to merge
33
commits into
turingschool-examples:main
from
BrandonDoza:feature/room-booking
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Write User Tests and Functions to Solve
Dashboard creation
Feature/view user bookings - completion of iteration 1
Add Bookings test/functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This PR allows a user to book a room, and cancel a booking
Related Issues
Fixes the issue of a user not being able to book a room or cancel a booking
Changes Made
With the feature addition, a user can now book a room, view that room in their booked rooms view, and from there they can choose to cancel a booking if they wish. They can book rooms by date, and filter those by room type as well.
Testing
Testing was done locally to make sure the expected outcomes we populating on the DOM. Since we are not testing DOM functions directly, the application was gone over with different paths the user may take to assure the outcome is as expected.
Checklist
Reviewer Instructions
When reviewing please refer to the domUpdates.js file to view the changes that were made.